interfaces: generalize constant folding for patterns #14526
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing constant folding mechanism for sequences-of-literals is now generalized to inject the literal into the following item, possibly reducing the complexity of the tree at the cost of making the tree contain longer strings. The tests are not fully adjusted, as the render test measures precise indices that were too tedious to fix on Friday. Signed-off-by: Zygmunt Krynicki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing constant folding mechanism for sequences-of-literals is now generalized to inject the literal into the following item, possibly reducing the complexity of the tree at the cost of making the tree contain longer strings.
The tests are not fully adjusted, as the render test measures precise indices that were too tedious to fix on Friday.
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?